Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ogc 1765 directory ticket apply change from archieve #1505

Merged

Conversation

Tschuppi81
Copy link
Contributor

@Tschuppi81 Tschuppi81 commented Sep 5, 2024

Ticket: Directory Entry Handler allows to withdraw ticket rejection

TYPE: Feature
LINK: ogc-1765

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have updated the PO files
  • I made changes/features for both org and town6
  • I have tested my code thoroughly by hand
  • I have added tests for my changes/features

Copy link

linear bot commented Sep 5, 2024

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (8d38490) to head (10e15dd).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
src/onegov/org/models/directory.py 68.75% 10 Missing ⚠️
src/onegov/org/models/ticket.py 94.11% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/models/ticket.py 88.64% <94.11%> (+0.16%) ⬆️
src/onegov/org/models/directory.py 87.15% <68.75%> (-2.80%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d38490...10e15dd. Read the comment docs.

@Tschuppi81
Copy link
Contributor Author

Tschuppi81 commented Sep 10, 2024

Do you think the icon for 'withdraw rejection' is appropriate?
Current:
image

Other options:
Screenshot from 2024-09-10 09-45-42
Screenshot from 2024-09-10 09-45-50

Copy link
Contributor

@BreathingFlesh BreathingFlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would see if you can separate the case of suggesting a new entry or suggesting an edit of an existing entry. Also I'd use the trash-restore icon.

@Tschuppi81 Tschuppi81 merged commit 0481241 into master Sep 11, 2024
13 of 14 checks passed
@Tschuppi81 Tschuppi81 deleted the feature/ogc-1765-directory-ticket-apply-change-from-archieve branch September 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants