Toggle Detail-view of file and hide rest if a new one is opened #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
|
Tschuppi81
approved these changes
Sep 11, 2024
| var detailRow = $('#details-' + fileNumber); | ||
|
|
||
| // Close all other detail rows | ||
| $('tr[id^="details-"]').not(detailRow).addClass('hidden'); |
There was a problem hiding this comment.
Personally, I wouldn't close the other detail rows and leave it to the user to close it. Like this one could compare to files..
There was a problem hiding this comment.
I thought about that too, but does one actually ever close a the details tab if the file isn't the right one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.
Commit message
Town6: Make file details closable
TYPE: Feature
LINK: OGC-1822
Checklist