Org: Avoids storing ORM objects in orm_cached properties

[Daverball]

Commit message

Org: Avoids storing ORM objects in orm_cached properties

This should improve reliability and should introduce less flaky behavior caused by incorrect merges of objects into the session.

TYPE: Bugfix
LINK: OGC-1813

Checklist

• I have performed a self-review of my code
• I have tested my code thoroughly by hand
• I have added tests for my changes/features

[linear]

OGC-1813 `orm-cached` is way too dangerous

[codecov]

Codecov Report

Attention: Patch coverage is 96.64634% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (d64955e) to head (be0fe12).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/onegov/activity/models/period.py	96.12%	5 Missing ⚠️
src/onegov/org/request.py	92.45%	4 Missing ⚠️
src/onegov/api/token.py	50.00%	1 Missing ⚠️
src/onegov/core/orm/cache.py	98.41%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
src/onegov/activity/__init__.py	100.00% <ø> (ø)
src/onegov/activity/collections/activity.py	94.09% <ø> (ø)
src/onegov/activity/collections/volunteer.py	63.63% <100.00%> (ø)
src/onegov/activity/models/__init__.py	100.00% <100.00%> (ø)
src/onegov/activity/models/activity.py	98.90% <100.00%> (ø)
src/onegov/core/cache.py	95.45% <ø> (ø)
src/onegov/core/orm/__init__.py	97.10% <100.00%> (-1.45%)	⬇️
src/onegov/core/orm/utils.py	100.00% <100.00%> (ø)
src/onegov/feriennet/app.py	96.77% <100.00%> (+0.04%)	⬆️
src/onegov/feriennet/boardlets.py	86.09% <100.00%> (-0.45%)	⬇️
... and 24 more

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64955e...be0fe12. Read the comment docs.