Mypy: Adds static type checking to CI/pre-commit #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very lax base config and does not add any annotations beyond the bare minimum to make mypy happy. But this allows us to get started on adding type annotations to our code and gradually make the config more strict for the parts of the code that is annotated.
Although this should be disabled by default... Maybe it's because we use ignore instead of extend-ignore?
Tschuppi81
pushed a commit
that referenced
this pull request
Jun 19, 2023
mypy: Enables static type checking This is a very lax base config and does not add any annotations beyond the bare minimum to make mypy happy. But this allows us to get started on adding type annotations to our code and gradually make the config more strict for the parts of the code that is annotated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message
Mypy: Adds static type checking to CI/pre-commit
This pulls in all the type stubs and fixes mypy errors in global scope i.e. the minimum
to start gradually adding type hints to the code base. The rules are very lax right now
and can be gradually made more strict for certain modules as we finish adding type
stubs to them.
Checklist