Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and performance improvements #17

Merged
merged 100 commits into from
Jun 15, 2024

Conversation

NonSwag
Copy link

@NonSwag NonSwag commented Jun 9, 2024

Description

This PR is rather unorganized, but in general it provides code quality and performance improvements

  • replaced XMaterials with Bukkit Materials
  • reworked how brushes work
  • removed unused and redundant code
  • abstracted brush settings to fight duplication
  • optimized brush algorithms
  • added proper error handling for fawe config creation
  • removed every static access to main class
  • organized almost every file
  • added a new brush called Underlay

Temporarily replaced the old broken surface mode algorithm with a simpler, faster and more intuitive one

known issue: exported brushes cannot be parsed anymore

I tested it quite a bit but cannot yet ensure that nothing else is broken

Checklist

  • I included all information required in the sections above
  • I tested my changes and approved their functionality
  • I ensured my changes do not break other parts of the code
  • Add a setting to the GUI to use either the old or new surface mode
  • Port to fawe brushes (or as temp solution fix the parsing)

@NonSwag NonSwag requested a review from a team as a code owner June 9, 2024 01:26
@NonSwag NonSwag self-assigned this Jun 9, 2024
@NonSwag NonSwag removed their assignment Jun 9, 2024
@NonSwag NonSwag requested a review from TheMeinerLP June 12, 2024 15:21
@NonSwag NonSwag enabled auto-merge June 13, 2024 16:37
Copy link

@theEvilReaper theEvilReaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small point to check

@NonSwag NonSwag requested a review from theEvilReaper June 13, 2024 19:52
Copy link

Quality Gate Passed Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Author

@NonSwag NonSwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my standpoint, there is nothing that needs to be addressed anymore.
All bugs, issues, inconsistencies and unwanted side effects that I could find are fixed now.
If you don't have anything to add, this pr is ready to be merged.

@NonSwag NonSwag added this pull request to the merge queue Jun 15, 2024
Merged via the queue into OneLiteFeatherNET:master with commit 9424341 Jun 15, 2024
6 checks passed
@TheMeinerLP TheMeinerLP mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants