-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup and performance improvements #17
Code cleanup and performance improvements #17
Conversation
# Conflicts: # src/main/java/net/onelitefeather/bettergopaint/BetterGoPaint.java # src/main/java/net/onelitefeather/bettergopaint/command/GoPaintCommand.java
temporarily disabled exported player brush
src/main/java/net/onelitefeather/bettergopaint/listeners/ConnectListener.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small point to check
src/main/java/net/onelitefeather/bettergopaint/utils/curve/BezierSpline.java
Outdated
Show resolved
Hide resolved
src/main/java/net/onelitefeather/bettergopaint/utils/curve/BezierSplineSegment.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my standpoint, there is nothing that needs to be addressed anymore.
All bugs, issues, inconsistencies and unwanted side effects that I could find are fixed now.
If you don't have anything to add, this pr is ready to be merged.
Description
This PR is rather unorganized, but in general it provides code quality and performance improvements
Underlay
Temporarily replaced the old broken surface mode algorithm with a simpler, faster and more intuitive one
known issue: exported brushes cannot be parsed anymoreI tested it quite a bit but cannot yet ensure that nothing else is broken
Checklist