Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect method which use a default position #102

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

theEvilReaper
Copy link

Proposed changes

The TestConnection class provides a method for connecting to the test server, which takes an Instance and a Pos as parameters. To enhance usability, this pull request introduces a new method that defaults to Pos.ZERO as the spawn position, simplifying test creation when the specific position is not critical.

The original method with two parameters remains unchanged, and its logic is unchanged too.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper requested a review from a team as a code owner November 18, 2024 10:03
Copy link
Collaborator

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@theEvilReaper theEvilReaper merged commit b2eea60 into master Nov 18, 2024
5 of 6 checks passed
@theEvilReaper theEvilReaper deleted the feature/testConnectionImprovements branch November 18, 2024 19:49
@theEvilReaper theEvilReaper restored the feature/testConnectionImprovements branch November 18, 2024 19:49
@theEvilReaper theEvilReaper deleted the feature/testConnectionImprovements branch November 19, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants