Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests and remove assert. #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheMeinerLP
Copy link
Collaborator

@TheMeinerLP TheMeinerLP commented Sep 30, 2024

This improves the handling of Namespace Keys in Minestom. Assert is misbehavior in that case and should never in production code. In 99% of cases, the assert will never match because of the default Java behaviour.
Check out following tutorial to understand why assert is not triggering: https://www.baeldung.com/java-assert

Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant