Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace own interpretation of Namespace with Adventure #79

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

TheMeinerLP
Copy link
Collaborator

@TheMeinerLP TheMeinerLP commented Sep 30, 2024

Proposed changes

This PR removes some overhead for the Namespace allocation in Minestom. Adventure ships already a class for that!

This pr initial a HARD FORK from Upstream

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@TheMeinerLP TheMeinerLP force-pushed the feature/remove-own-implementation-of-key branch from f02fbc9 to 8774e4c Compare November 3, 2024 18:58
@TheMeinerLP TheMeinerLP marked this pull request as ready for review November 3, 2024 19:00
@TheMeinerLP TheMeinerLP requested a review from a team as a code owner November 3, 2024 19:00
@TheMeinerLP TheMeinerLP added the HARDFORK Breaks everything to upstream label Nov 3, 2024
@TheMeinerLP TheMeinerLP force-pushed the feature/remove-own-implementation-of-key branch from ae81f4f to c9988be Compare November 11, 2024 09:53
@TheMeinerLP TheMeinerLP force-pushed the feature/remove-own-implementation-of-key branch from c9988be to b8e76ea Compare November 11, 2024 10:05
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.5% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature HARDFORK Breaks everything to upstream
Projects
Status: 🚩 Ready
Development

Successfully merging this pull request may close these issues.

2 participants