Merge pull request #2129 from OneSignal/fix/xiaomi_foreground_on_click

[Fix] Xiaomi notification click not foregrounding app
OneSignal · Jun 18, 2024 · 00e1792 · 00e1792
2 parents f5bf424 + 8f66f8e
commit 00e1792
Showing 1 changed file with 12 additions and 18 deletions.
diff --git a/...ns/src/main/java/com/onesignal/notifications/activities/NotificationOpenedActivityBase.kt b/...ns/src/main/java/com/onesignal/notifications/activities/NotificationOpenedActivityBase.kt
@@ -36,32 +36,26 @@ import com.onesignal.notifications.internal.open.INotificationOpenedProcessor
 abstract class NotificationOpenedActivityBase : Activity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        if (!OneSignal.initWithContext(applicationContext)) {
-            return
-        }
-
-        var self = this
-
-        suspendifyOnThread {
-            var openedProcessor = OneSignal.getService<INotificationOpenedProcessor>()
-            openedProcessor.processFromContext(self, intent)
-        }
-
-        finish()
+        processIntent()
     }
 
     override fun onNewIntent(intent: Intent) {
         super.onNewIntent(intent)
+        processIntent()
+    }
+
+    private fun processIntent() {
         if (!OneSignal.initWithContext(applicationContext)) {
             return
         }
-
-        var self = this
         suspendifyOnThread {
-            var openedProcessor = OneSignal.getService<INotificationOpenedProcessor>()
-            openedProcessor.processFromContext(self, getIntent())
+            val openedProcessor = OneSignal.getService<INotificationOpenedProcessor>()
+            openedProcessor.processFromContext(this, intent)
+            // KEEP: Xiaomi Compatibility:
+            // Must keep this Activity alive while trampolining, that is
+            // startActivity() must be called BEFORE finish(), otherwise
+            // the app is never foregrounded.
+            finish()
         }
-
-        finish()
     }
 }