-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new remote params #1076
Add new remote params #1076
Conversation
1c71bdd
to
e1a2472
Compare
e1a2472
to
cbd417a
Compare
54cfba8
to
130a023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this branch should be rebased to major_release_4.0.0
, looks like we are avoiding breaking changes in this PR but there should be breaking changes because we are removing specific variables and methods and replacing them with the remote param methods and defaults.
130a023
to
4066139
Compare
4066139
to
c9eee53
Compare
* Add unsubscribeWhenNotificationAreDisable remote param * Add disableGMSMissingPrompt remote param * Add locationShared remote param * Add requiresUserPrivacyConcent remote param * Keep public method * Add tests for new getters
c9eee53
to
736f3bb
Compare
* Move task management to TaskController * Delay task until remote params and init is done * After task delayed, check again for user consent * Fix test, add tests
Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/model/MainActivityViewModel.java
Show resolved
Hide resolved
...les/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/model/SplashActivityViewModel.java
Outdated
Show resolved
Hide resolved
...les/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/model/SplashActivityViewModel.java
Outdated
Show resolved
Hide resolved
Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java
Outdated
Show resolved
Hide resolved
OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java
Outdated
Show resolved
Hide resolved
OneSignalSDK/unittest/src/test/java/com/onesignal/InAppMessagingHelpers.java
Show resolved
Hide resolved
OneSignalSDK/unittest/src/test/java/com/onesignal/ShadowOneSignalRestClient.java
Show resolved
Hide resolved
OneSignalSDK/unittest/src/test/java/com/test/onesignal/RESTClientRunner.java
Outdated
Show resolved
Hide resolved
OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java
Show resolved
Hide resolved
OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java
Outdated
Show resolved
Hide resolved
ac30cb8
to
b43e72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit on an extra if statement.
OneSignalSDK/onesignal/src/main/java/com/onesignal/LocationController.java
Show resolved
Hide resolved
OneSignalSDK/unittest/src/test/java/com/onesignal/ShadowOneSignalRestClient.java
Show resolved
Hide resolved
b43e72b
to
e7b5e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add new remote params * Add unsubscribeWhenNotificationAreDisable remote param * Add disableGMSMissingPrompt remote param * Add locationShared remote param * Add requiresUserPrivacyConcent remote param * Keep public method * Add tests for new getters * Add task delay due to requiring consent from remote params * Move task management to TaskController * Delay task until remote params and init is done * After task delayed, check again for user consent * Fix test, add tests * Remove extra check/schedule on pending tasks
This change is