Notification Open now uses an Activity instead of Broadcast #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to using NotificationOpenedActivity.class in GenerateNotification.java * Remove Intent flags from startOrResumeApp and use Activity Context instead of the normal context * Update tests to account for the new behavior
Jeasmine
force-pushed
the
feature/notification-open-broadcastreceiver
branch
from
f921cb8
to
edcb4e3
Compare
jkasten2
reviewed
Oct 26, 2020
OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java
Outdated
Show resolved
Hide resolved
* Using activities for handling delete can end on some weird behavior on the UI
Jeasmine
force-pushed
the
feature/notification-open-broadcastreceiver
branch
from
49d42e0
to
211e23d
Compare
jkasten2
requested changes
Nov 9, 2020
OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java
Outdated
Show resolved
Hide resolved
OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java
Outdated
Show resolved
Hide resolved
OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java
Outdated
Show resolved
Hide resolved
jkasten2
approved these changes
Nov 10, 2020
jkasten2
changed the title
jkasten2
added a commit
that referenced
this pull request
Feb 3, 2021
* Main activity wasn't luanching when tapping on a notification that resulted in the app being cold started. * This was fixed by adding a missing startActivity and removing an unneeded PendingIntent * This was a bug interduced in PR #1192 in 4.0.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle delete intent with broadcast receiver …
Tested on API 21, 25, 29
This change is