Add auth hash to external Id #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
c8e8cd1
to
212a5ff
Compare
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
212a5ff
to
e949f47
Compare
jkasten2
approved these changes
Nov 16, 2020
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
e949f47
to
10b3beb
Compare
jkasten2
requested changes
Nov 17, 2020
| @@ -1565,8 +1595,20 @@ public void run() { | |||
| return; | |||
| } | |||
|
|
|||
| if (remoteParams != null && remoteParams.useEmailAuth && externalIdAuthHash == null) { | |||
There was a problem hiding this comment.
remoteParams.useEmailAuth should be remoteParams.useUserIdAuth
emawby
suggested changes
Nov 17, 2020
| return; | ||
| } | ||
|
|
||
| String internalExternalIdAuthHash = externalIdAuthHash; |
There was a problem hiding this comment.
Can we change the name of internalExternalIdAuthHash? Is the only change we are making is making it all lower case? If that is the case maybe include the lowercase aspect in the name?
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
10b3beb
to
aa99221
Compare
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
aa99221
to
d1090fd
Compare
* Add auth to setExternalId * Add tests for new functionality
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
d1090fd
to
3d2ef2c
Compare
jkasten2
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs name params validation
This change is