SMS integration

[Jeasmine]

SMS Integration

Emulates current channel email behavior, but in this case, for the new channel SMS.

Since most of the work between SMS and Email is the same, a parent class UserStateSecondaryChannelSynchronizer was created. This will hold all core functionality.

• Added setSMSNumber public function
• Add SMS observers
• Add SMS data to DeviceState
• Add UserStateSMSSynchronizer and UserStateSecondaryChannelSynchronizer files, share email and SMS logic under UserStateSecondaryChannelSynchronizer
• Move players and channel tests to SynchronizerIntegrationTests

Difference between SMS and email, not parent_player_id is sent (this is removed on logout PR), we relay on external_id

It is recommended to review commit by commit. The core implementation is done on the firsts commit, then on each test commit changes are made to make the feature truly work.

This change is 

[jkasten2]

Overall PR looks good, really like the work put into splitting up the tests here!

Reviewed 10 of 22 files at r1, 14 of 15 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @emawby, @gonzalonarbaiz, and @Jeasmine)

---

OneSignalSDK/onesignal/src/main/java/com/onesignal/UserStateEmailSynchronizer.java, line 48 at r3 (raw file):

    @Override
    void logoutSMS() {

This class has logoutEmail() and logoutSMS(), I would expect logoutChannel() instead. I haven't looked at your other PR so this might be addressed.

---

OneSignalSDK/unittest/src/test/java/com/test/onesignal/LocationIntegrationTests.java, line 86 at r3 (raw file):

)
@RunWith(RobolectricTestRunner.class)
public class LocationIntegrationTests {

💯 Nice clean up moving this to a different file!

[Jeasmine]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @emawby, @gonzalonarbaiz, and @jkasten2)

---

OneSignalSDK/onesignal/src/main/java/com/onesignal/UserStateEmailSynchronizer.java, line 48 at r3 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

This class has logoutEmail() and logoutSMS(), I would expect logoutChannel() instead. I haven't looked at your other PR so this might be addressed.

I Will address this on the logout PR! thanks for pointing this out, I agree 100%

---

OneSignalSDK/unittest/src/test/java/com/test/onesignal/LocationIntegrationTests.java, line 86 at r3 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

💯 Nice clean up moving this to a different file!

🔥

[jkasten2]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @emawby and @gonzalonarbaiz)

[jkasten2]

Reviewed 10 of 10 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @emawby and @gonzalonarbaiz)