Fix crash when receiving IAM on android #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking 20.2.2 that was causing the app to crash.
Jeasmine
reviewed
Jan 26, 2021
| @@ -5,7 +5,7 @@ ext { | |||
|
|
|||
| androidXVersion = '[1.0.0, 1.99.99]' | |||
| androidWorkVersion = '[2.0.0, 2.99.99]' | |||
| firebaseMessagingVersion = '[19.0.0, 20.99.99]' | |||
| firebaseMessagingVersion = '[19.0.0, 21.99.99]' | |||
There was a problem hiding this comment.
Can you put more information about the error and what specific under this version solve the problem?
There was a problem hiding this comment.
Yes, there is a known issue https://firebase.google.com/support/release-notes/android#messaging_v20-2-2 and we are asked not to use this version. For some reason I couldn't find when the version range is set to [19.0.0, 20.99.99] on my builds didn't go for 20.3.0 which already has a fix for that.
jkasten2
approved these changes
Jan 29, 2021
Jeasmine
approved these changes
Feb 2, 2021
|
It seems like users are facing this issue check #1267 this should be merge and ready for the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The range that we were using was causing that gradle build to use version 20.2.2 of the firebase messaging library, which was making the app crash.
That error is fixed on later versions of the library.
This error is reported in https://firebase.google.com/support/release-notes/android#messaging_v20-2-2
This change is