Feature/add onesignal suppress launch urls #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check, and should be done after, at other point of the app open process.
Jeasmine
reviewed
Jan 29, 2021
Jeasmine
reviewed
Jan 29, 2021
OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java
Show resolved
Hide resolved
jkasten2
requested changes
Feb 1, 2021
There was a problem hiding this comment.
I also recommend adding a false test case as noted in:
https://github.com/OneSignal/OneSignal-Android-SDK/pull/1268/files#r567015270
Otherwise PR looks good after this.
Jeasmine
approved these changes
Feb 2, 2021
jkasten2
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is