Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new method to get TZid. #1270

Merged
merged 7 commits into from
Feb 16, 2021
Merged

Added new method to get TZid. #1270

merged 7 commits into from
Feb 16, 2021

Conversation

gonzalonarbaiz
Copy link
Contributor

@gonzalonarbaiz gonzalonarbaiz commented Jan 29, 2021

tests are missing and we have to validate with BE team the id to be used.

This change is Reviewable

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add a unit test
  • nit on extra import we don't need to include

@gonzalonarbaiz gonzalonarbaiz changed the title WIP! added new method to get TZid. Added new method to get TZid. Feb 2, 2021
Copy link
Contributor Author

@gonzalonarbaiz gonzalonarbaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gonzalonarbaiz gonzalonarbaiz merged commit a07c6fe into master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants