[Change] After opening a notification with a URL deeplink, the back button will return to the previous Activity #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing FLAG_ACTIVITY_NO_HISTORY so the user can see the Activity to go back to it if they background the app. Also removed other flags so when the user press the back button on the device they are taken to the last Activity in the app if the URL is a deeplink. If the browser is open then it is it's own task and pressing the back button will then take them to the home screen, however the app's task will remind in the list so the user can always get back to where they left off in the app. There isn't any details into why these flags were added, they date back to the 2.0.0 release of this SDK: ce5ad7d#diff-2708f86f77e539cab647ecede9d5fcbead3bf0f954d7f9e536eafbc78ba760d6R792 However given that the user experience is much better in these cases this is a better default. If the URL is a deeplink the app developer could always add other Activity setting to their AndroidManifest.xml for additional control.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
After opening a notification with a URL deeplink, the back button will return to the previous Activity. Also allow URLs that open the browser to keep task in the task list.
Details
Motivation
It is a better default user experience if the User taps on a notification that deeplinks into that app and it takes them back to the last screen they were on after pressing back. Also with the removal of the
FLAG_ACTIVITY_NO_HISTORYthe user can resume the app or site they if they background it.https://app.asana.com/0/1202082526817210/1202301497858860/f
Scope
Only affects notification opens with URLs.
Testing
Unit testing
No existing Unit Test to update. Specific Intent flags are not fully implemented in Robolectric.
Manual testing
Tested on Android 12 and Android 6 emulators. Tested both a deep link URL and a URL that opens the browser. Tested wit the app backgrounded, swiped away, and kicked out of memory. Pressed the back button in each of these cases to ensure the behavior was correct.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is