Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Model - Update privacy consent property names #1771

Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented May 3, 2023

Description

One Line Summary

Update the privacy consent property names

Details

requiresPrivacyConsent has become consentRequired()
privacyConsent has become consentGiven()

Also fixes outcomes unit tests so unit tests now pass

Motivation

simplify api

Scope

privacy consent

Testing

Unit testing

Fix outcomes unit tests

Manual testing

Test privacy consent on an emulator

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

emawby added 2 commits May 3, 2023 14:03
requiresPrivacyConsent -> consentRequired
privacyConsent -> consentGiven
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jennantilla, @nan-li, and @shepherd-l)

@emawby emawby merged commit 5064005 into user-model/add_to_json_object May 4, 2023
@emawby emawby deleted the user-model/update_privacy_consent_names branch May 4, 2023 17:27
@emawby emawby mentioned this pull request May 4, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…sent_names

User Model - Update privacy consent property names
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…sent_names

User Model - Update privacy consent property names
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
…sent_names

User Model - Update privacy consent property names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants