Upgrade play-services-basement to 18.1.0 #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded firebase-messaging from 23.0.0 -> 23.0.8, which upgrades to play-services-basement:18.1.0. Removed direct dependency reference to com.google.android.gms:play-services-base. Version locking isn't recommened for this specific dependency, since other things depend on it like com.google.firebase:firebase-messaging.
When we upgrade to FCM 23.0.8 they changed the defintion to tokenTask.exception to be possiblity null. Updated our code to handle thier change. Changes above also exposed the getToken defintion was out of sync with between PushRegistratorAbstractGoogle and PushRegistratorFCM so this was addressed.
jkasten2
changed the title
jinliu9508
reviewed
Feb 8, 2024
jinliu9508
approved these changes
Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Google recommends updating to
play-services-basement:18.1.0.Details
Bumped
firebase-messagingfrom23.0.0to23.0.8. It has a dependency onplay-services-basement:18.1.0which gives us the recommended version. Also removed our direct dependency onplay-services-baseas this can easily get out of sync with other Google libraries when when we update them, such asfirebase-messagingwe updated in this PR. See commit message for even more details.Motivation
Google recommends updating to
play-services-basement:18.1.0.Scope
Only changes required to update
firebase-messagingand updated required code, which also gives us an updatedplay-services-basement.Testing
Unit testing
Manual testing
Tested a new installed on an Android 14 emulator, ensuring we still get a FCM push token.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is