Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value to legacy notification types #1986

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Add default value to legacy notification types #1986

merged 3 commits into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. Simulate a crash scenario by adding a random legacy player id

    @jinliu9508
    jinliu9508 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    485f958 View commit details
    Browse the repository at this point in the history

  2. Apply the fix to prevent the crash

    @jinliu9508
    jinliu9508 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c41b921 View commit details
    Browse the repository at this point in the history

  3. Clean up code for testing

    @jinliu9508
    jinliu9508 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    cab7cb1 View commit details
    Browse the repository at this point in the history