Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firebase-messaging version to 23.4.0 #1987

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jinliu9508
Copy link
Contributor

@jinliu9508 jinliu9508 commented Feb 9, 2024

Description

One Line Summary

Update prefer version of firebase-messaging to 23.4.0

Details

Motivation

Several users have reported that updating the version of firebase-messaging resolves the 'Subscription can't change notification_types to positive integer while disabled' issue. Although a more precise cause is still under investigation, this change doesn't seem to break any existing functionality.

Testing

Manual testing

I am unable to reproduce the issue, as it seems to occur only for certain users, and the environment data is unclear at this moment.
I have tested push notification sent from the portal, push notification with the app closed, push notification on new install, and push notification click. The test was conducted on pixel 7 emulator with api 33. Everything works as expected.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on the require version range.

Also can you note what was tested and on what device / android version in the PR?

  • Testing registering on a new install and that notifications display is normally all we need to test when updating the FCM library.

OneSignalSDK/onesignal/notifications/build.gradle Outdated Show resolved Hide resolved
@jinliu9508
Copy link
Contributor Author

Left a comment on the require version range.

Also can you note what was tested and on what device / android version in the PR?

  • Testing registering on a new install and that notifications display is normally all we need to test when updating the FCM library.

Ok, I have updated the PR description with the testing environment and the testing units I have done for this PR.

@jinliu9508 jinliu9508 merged commit 6fb2987 into main Feb 9, 2024
1 of 2 checks passed
@jinliu9508 jinliu9508 deleted the Update-firebase-message branch February 9, 2024 20:49
@jinliu9508 jinliu9508 mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants