[Fix] Duplicate GET /user call on cold start when calling login with the same external_id

[jkasten2]

Description

One Line Summary

Omit making a GET /user call on cold start when calling login on the same external_id.

Details

We already refresh when the app is cold started, so this results in two GET calls back-to-back for apps that call login every time the app is opened the by the user. We are still refreshing the user if switch user happens.

Motivation

Optimize network calls is beneficial to the device and OneSignal's backend.

Scope

Only effects OneSignal.login, only omitting an extra get User call.

Testing

Unit testing

Adding a test is out of scope for this PR, since there is no existing test infrastructure to test code in OneSignalImp. Also such code should be refactored out into a different class to make it more testable anyway.

Manual testing

Test on an Android 14 emulator.

Before

After

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

---

This change is