Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update supported android versions in readme to include Android 14 #2024

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Mar 7, 2024

Description

One Line Summary

Updated tested / supported Android versions in repos readme.

Details

Motivation

Developer use the readme to evaluate libraries before using, it is import Android versions are up to date so they know what is supported.

Scope

Only update Android versions in the Readme.

History

We support Android 14 (API 34) for a while but this readme was never updated. Also since OneSignal-Android-SDK 5.0.0 we only support Android 5.0 (API 21).

Testing

Unit testing

N/A

Manual testing

N/A

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

We support Android 14 (API 34) for a while but this readme was never
updated. Also since OneSignal-Android-SDK 5.0.0 we only support
Android 5.0 (API 21).
Base automatically changed from tests/switch-to-kotest-extensions-android to main March 12, 2024 17:40
@jkasten2 jkasten2 merged commit 25924dc into main Mar 12, 2024
2 checks passed
@jkasten2 jkasten2 deleted the docs/updated-android-versions-android14 branch March 12, 2024 17:41
@jkasten2 jkasten2 mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants