-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/fcm push token bug #2125
Merged
Merged
Fix/fcm push token bug #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgomezp
force-pushed
the
fix/fcm-push-token-bug
branch
from
June 13, 2024 22:17
d9f6baa
to
3c43046
Compare
jkasten2
requested changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, also looks like the failing test is due to this change and has to be updated.
...n/java/com/onesignal/user/internal/operations/impl/executors/RefreshUserOperationExecutor.kt
Outdated
Show resolved
Hide resolved
...n/java/com/onesignal/user/internal/operations/impl/executors/RefreshUserOperationExecutor.kt
Outdated
Show resolved
Hide resolved
jkasten2
approved these changes
Jun 17, 2024
...n/java/com/onesignal/user/internal/operations/impl/executors/RefreshUserOperationExecutor.kt
Outdated
Show resolved
Hide resolved
...n/java/com/onesignal/user/internal/operations/impl/executors/RefreshUserOperationExecutor.kt
Outdated
Show resolved
Hide resolved
rgomezp
force-pushed
the
fix/fcm-push-token-bug
branch
from
June 17, 2024 19:26
4e40f06
to
27bd952
Compare
Motivation: since we're replacing the config model every time, this is already being called. We don't need to call it again in `start`
Motivation: the backend should sync its push token state with the client state (truth) since it's the client that gets the token directly when subscribing -- as opposed to the client syncing with whatever comes in from the backend.
… subscription not being refreshed from backend.
rgomezp
force-pushed
the
fix/fcm-push-token-bug
branch
from
June 17, 2024 19:31
27bd952
to
c832f1b
Compare
Merged
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One line summary: Remove redundant
retrievePushToken
call and refine local model replacement logic.Details
Motivation
Remove Unnecessary
retrievePushToken
CallThe
retrievePushToken
call in thestart
function has been removed. Since the config model is replaced every time, this call is redundant.Replace Local Models with Non-Push Subscriptions
Local models are now only replaced with non-push subscriptions. The backend should sync its push token state with the client state, as the client directly obtains the token during subscription.
Testing
Manual testing
Tested locally.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is