Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] NotificationPermissionController fix an override method signature #2132

Merged
merged 1 commit into from
Jun 18, 2024
+6 −6
Merged

[fix] NotificationPermissionController fix an override method signature #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...com/onesignal/notifications/internal/permissions/impl/NotificationPermissionController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ internal class NotificationPermissionController(
private fun registerPollingLifecycleListener() {
_applicationService.addApplicationLifecycleHandler(
object : ApplicationLifecycleHandlerBase() {
override fun onFocus() {
super.onFocus()
override fun onFocus(firedOnSubscribe: Boolean) {
super.onFocus(firedOnSubscribe)
pollingWaitInterval = _configModelStore.model.foregroundFetchNotificationPermissionInterval
pollingWaiter.wake()
}
Expand Down
8 changes: 4 additions & 4 deletions .../com/onesignal/notifications/internal/permission/NotificationPermissionControllerTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class NotificationPermissionControllerTests : FunSpec({
// call onFocus to set the proper polling interval.
// This happens when registering the lifecycle handler
for (focusHandler in focusHandlerList) {
focusHandler.onFocus()
focusHandler.onFocus(false)
}

// When
Expand Down Expand Up @@ -99,7 +99,7 @@ class NotificationPermissionControllerTests : FunSpec({
// call onFocus to set the proper polling interval.
// This happens when registering the lifecycle handler
for (focusHandler in handlerList) {
focusHandler.onFocus()
focusHandler.onFocus(false)
}

// When
Expand Down Expand Up @@ -142,7 +142,7 @@ class NotificationPermissionControllerTests : FunSpec({
// call onFocus to set the proper polling interval.
// This happens when registering the lifecycle handler
for (focusHandler in handlerList) {
focusHandler.onFocus()
focusHandler.onFocus(false)
}

// When
Expand All @@ -156,7 +156,7 @@ class NotificationPermissionControllerTests : FunSpec({
delay(100)
// the app regains focus
for (handler in handlerList) {
handler.onFocus()
handler.onFocus(false)
}
delay(5)

Expand Down
Loading