Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback code for FCM pre-21.0.0 #2148

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jul 16, 2024

Description

One Line Summary

We bumped the minimum firebase-messaging version to 21.0.0 in the build.gradle a while ago but never cleaned up the old per-21.0.0 fallback code.

Details

Motivation

Cleaning up dead code to make the SDK a bit smaller and easier to read.

Scope

Only effects FCM push token registration.

Testing

Manual testing

Tested on an Android 14 emulator.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

We bumped firebase-messaging in the build.gradle a while ago but never cleaned
Base automatically changed from clean-up-android-support-library-references to main July 16, 2024 19:49
@jkasten2 jkasten2 merged commit ec71f7e into main Jul 16, 2024
2 checks passed
@jkasten2 jkasten2 deleted the cleanup-pre-fcm-21-support branch July 16, 2024 19:51
@jinliu9508 jinliu9508 mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants