Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New init method does not have privacy consent check #786

Merged
merged 1 commit into from
Jul 1, 2019
Merged

New init method does not have privacy consent check #786

merged 1 commit into from
Jul 1, 2019

Conversation

mikechoch
Copy link
Contributor

@mikechoch mikechoch commented Jun 29, 2019 •
edited by jkasten2
Loading

  • Moved privacy consent check from old init and placed it in the newest init so the Manifest com.onesignal.PrivacyConsent check occurs

This change is Reviewable

@mikechoch
New init method does not have privacy consent check
e79a5e6 
* Moved it from old init and placed it in the newest init so
the Manifest com.onesignal.PrivacyConsent check occurs
jkasten2
jkasten2 approved these changes Jun 29, 2019
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mikechoch mikechoch merged commit 3eea489 into master Jul 1, 2019
@Jeasmine Jeasmine deleted the fix_requires_privacy_consent_init branch May 12, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkasten2 jkasten2 jkasten2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechoch @jkasten2