Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuspec for .net7 #93

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Update nuspec for .net7 #93

merged 1 commit into from
Jan 29, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Jan 26, 2024

Description

One Line Summary

Fix the nuspec to reflect the bump to .net7 build tools.

Details

Remove the monoandroid (xamarin) target and update the file paths correctly

Motivation

enable release

Testing

Manual testing

Tested the nupkg locally in a test app

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

<file src="OneSignalSDK.DotNet\bin\Release\net7.0-ios10.0\OneSignalSDK.DotNet.Core.dll" target="lib\net7.0-ios10.0" />
<file src="OneSignalSDK.DotNet\bin\Release\net7.0-ios10.0\OneSignalSDK.DotNet.iOS.dll" target="lib\net7.0-ios10.0" />
<file src="OneSignalSDK.DotNet\bin\Release\net7.0-ios10.0\OneSignalSDK.DotNet.iOS.Binding.dll" target="lib\net7.0-ios10.0" />
<!--net7.0(minimum runtime 9.0)-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minimum runtime 9.0) I believe this orignal comment was referring to iOS. Let's update the comment to include iOS or remove the comment.

@emawby emawby merged commit 6fc6d1e into user-model/main Jan 29, 2024
1 check passed
@emawby emawby deleted the update_nuspec_for_net7 branch January 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants