Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] iOS notifications clicked event to fire on cold start #641

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Sep 26, 2023

Description

One Line Summary

Fixes iOS notifications clicked event to fire when the app was cold started from clicking a notification.

Details

Motivation

Fixes #638 iOS bug where Notifications.Clicked event is set but does not fire when clicking the notification cold starts the app.

Testing

Manual testing

Tested clicking on notifications when the app in the foreground, background, and closed, app build with Unity 2021.3.16f1 of the OneSignal example app on a physical iPhone 12 with iOS 15.5.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@shepherd-l shepherd-l changed the title [Fix] iOS notifications clicked event on app open [Fix] iOS notifications clicked event to fire on cold start Sep 26, 2023
@shepherd-l shepherd-l merged commit 8e01414 into user-model/main Sep 26, 2023
1 check passed
@shepherd-l shepherd-l deleted the fix/iOSNotificationClicked branch September 26, 2023 23:14
jinliu9508 pushed a commit that referenced this pull request Feb 23, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508 pushed a commit that referenced this pull request Mar 1, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] iOS notifications clicked event on app open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants