Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] [CD] [CI] Update Ubuntu version and remove no longer needed Python2 #1060

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jul 26, 2023

Description

1 Line Summary

Remove old Python2 from CI/CD that is no longer used and updated to ubuntu-22.04.

Details

We want to ensure we aren't running Python2 as it is no longer being updated. Also needed to bump ServiceWorker size check by 1KB as it started failing since an early rebase.

Validation

Tests

Ensured both CI and CD task ran successfully on Github.

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

@jkasten2 jkasten2 changed the base branch from main to user-model/v1 July 26, 2023 00:38
@jkasten2 jkasten2 changed the base branch from user-model/v1 to user-model/fixups-from-2023-07-25-rebase July 26, 2023 01:04
Since the rebase on main the service worker file grew in size by
1KB or so. Bumping so CD does not fail.
@jkasten2 jkasten2 changed the title [WIP] User model/rm python2 [User Model] [CD] [CI] Update Ubuntu version and remove no longer needed Python2 Jul 26, 2023
Base automatically changed from user-model/fixups-from-2023-07-25-rebase to user-model/v1 July 27, 2023 20:59
@jkasten2 jkasten2 merged commit eddc6b2 into user-model/v1 Jul 27, 2023
2 checks passed
@jkasten2 jkasten2 deleted the user-model/rm-python2 branch July 27, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants