[User Model] [Fix] Bell not updating to subscribed state #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bell.ts was expecting getPermissionStatus to accept a callback but it not currently. Typescript did not fail as OneSignal isn't imported in this file which was also corrected in this commit. This was causing the bell not to updated when accepting notifications and after the push subscription was created.
Remove old public API test of non-existent OneSignal.Notifications.getPermissionStatus()
Base automatically changed from
user-model/fix-permission-change-event-stops-firing
to
user-model/v1
August 2, 2023 21:42
jkasten2
deleted the
user-model/fix-bell-not-updating-to-subscribed-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Fix bug where the bell would not update it's visual state when becomes subscribed.
Details
Validation
Tests
Test with Chrome on macOS, ensured bell grayed out and decreased in size after the push subscribed we was created.
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is