[User Model] [Fix] Notification permission change event type to boolean #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improving this readability as we are going to add some more tests using this in a follow up commit in this PR.
Rename NATIVE_PROMPT_PERMISSIONCHANGED to NOTIFICATION_PERMISSION_CHANGED_AS_STRING. This is much more accurate name, also ended with "AS_STRING" as we will add a "AS_BOOLEAN" copy of this event in the next commit.
Added test to ensure the correct value is fired on the PermissionChange event. Also test to ensure removeEventListener also works.
Add NOTIFICATION_PERMISSION_CHANGED_AS_BOOLEAN to fire public event.
This closer matches our public API
Base automatically changed from
user-model/fix-bell-not-updating-to-subscribed-state
to
user-model/v1
August 2, 2023 21:42
rgomezp
requested changes
Aug 4, 2023
rgomezp
approved these changes
Aug 4, 2023
jkasten2
deleted the
user-model/fix-notification-permission-change-event-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Correct
OneSignal.Notification.addEventListener("permissionChange", function....)to provide abooleaninstead of astring.Details
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is