Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official AMP Plugin Support - Workaround #258

Closed
rgomezp opened this issue Nov 13, 2020 · 1 comment
Closed

Official AMP Plugin Support - Workaround #258

rgomezp opened this issue Nov 13, 2020 · 1 comment

Comments

@rgomezp
Copy link
Contributor

rgomezp commented Nov 13, 2020

For the official AMP plugin, you should be able to manually set it up like a non-WP site by following this: https://documentation.onesignal.com/docs/amp-web-push-setup#how-to-set-up-web-push-on-amp-pages-non-wordpress

The only thing to note is you have to put the OneSignalSDKWorker.js file under a sub folder like /push instead of root so it doesn't fight for control with the AMP Service Worker. You should also add the service-worker-scope setting to the amp-web-push tag and set it to /push .

@rgomezp
Copy link
Contributor Author

rgomezp commented Mar 10, 2022

We now support the Official AMP plugin automatically

@rgomezp rgomezp closed this as completed Mar 10, 2022
@jkasten2 jkasten2 unpinned this issue Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant