Skip to content

Commit

Permalink
OneSignalFramework always includes OneSignalLiveActivities on any pla…
Browse files Browse the repository at this point in the history
…tform

* OneSignalFramework has a dependency on OneSignalLiveActivities. It was previously only including the dependency on iOS platform only.
* It is true that OneSignalLiveActivities is not supported on Mac Catalyst but people using the SDK without Live Activities couldn't build due to OneSignalFramework couldn't find OneSignalLiveActivities.
* The change made is to include OneSignalLiveActivities on any platform.
* Note that OneSignalLiveActivities itself is not supported on Mac Catalyst.
  • Loading branch information
nan-li committed Jun 5, 2024
1 parent 25f0657 commit c20ec2c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
475F47442B8E3A0A00EC05B3 /* OSRequestSetUpdateToken.swift in Sources */ = {isa = PBXBuildFile; fileRef = 475F473F2B8E3A0A00EC05B3 /* OSRequestSetUpdateToken.swift */; };
475F47452B8E3A0A00EC05B3 /* OSLiveActivityRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 475F47402B8E3A0A00EC05B3 /* OSLiveActivityRequest.swift */; };
475F47462B8E3A0A00EC05B3 /* OSRequestRemoveStartToken.swift in Sources */ = {isa = PBXBuildFile; fileRef = 475F47412B8E3A0A00EC05B3 /* OSRequestRemoveStartToken.swift */; };
475F474A2B8E3B4600EC05B3 /* OneSignalLiveActivities.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 475F471E2B8E398D00EC05B3 /* OneSignalLiveActivities.framework */; platformFilter = ios; };
475F474A2B8E3B4600EC05B3 /* OneSignalLiveActivities.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 475F471E2B8E398D00EC05B3 /* OneSignalLiveActivities.framework */; };
475F474F2B8E3B5400EC05B3 /* OneSignalLiveActivities.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 475F471E2B8E398D00EC05B3 /* OneSignalLiveActivities.framework */; };
475F47502B8E3B5400EC05B3 /* OneSignalLiveActivities.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 475F471E2B8E398D00EC05B3 /* OneSignalLiveActivities.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
47A885CD2BB317B300ED91FA /* AnyCodable.swift in Sources */ = {isa = PBXBuildFile; fileRef = 47A885CC2BB317B300ED91FA /* AnyCodable.swift */; };
Expand Down Expand Up @@ -4237,7 +4237,6 @@
};
475F474D2B8E3B4600EC05B3 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
platformFilter = ios;
target = 475F471D2B8E398D00EC05B3 /* OneSignalLiveActivities */;
targetProxy = 475F474C2B8E3B4600EC05B3 /* PBXContainerItemProxy */;
};
Expand Down

0 comments on commit c20ec2c

Please sign in to comment.