Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with direct influence but nil direct id #1311

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Sep 5, 2023

Description

One Line Summary

Fixes a crash when a session has a direct influence but the direct id is nil.
Fixes #1310

Details

This does not resolve getting into this situation in the first place since we should not have a direction session without a direct id, but this will at least prevent a crash when the issue happens. Instead we will log an error.

Motivation

prevent crash

Scope

direct influences

Testing

Unit testing

added a unit test for this case

Manual testing

I could not reproduce the case with a direct influence but no id

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby merged commit 6cf727b into main Sep 6, 2023
1 of 2 checks passed
@emawby emawby deleted the Fix/direct_id_crash branch September 6, 2023 22:33
@emawby emawby mentioned this pull request Sep 7, 2023
nan-li added a commit that referenced this pull request Oct 25, 2023
nan-li added a commit that referenced this pull request Oct 25, 2023
nan-li added a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash on OneSignal.initWithLaunchOptions(_:)
5 participants