Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.1.2 #1381

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Release 5.1.2 #1381

merged 3 commits into from
Mar 6, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Mar 6, 2024 •
edited by jwilm
Loading

What's Changed

⚠️ Behavior Changes

  • When you call the jsonRepresentation method of OSPushSubscriptionState, if a property is null, the value will now be "" instead of the string literal "nil" #1373

🐛 Bug Fixes & Misc Improvements

  • Rename internal method that was called setSharedInstance to workaround false App Store flagging #1375
  • Improve Swift concurrency safety to address crash reports in production #1376
  • For our server: Add OneSignal-Subscription-Id to Create User request which improves last_active data #1372

This change is Reviewable

@nan-li
Copy link
Contributor Author

nan-li commented Mar 6, 2024

Our released version 5.1.1 causes a build error for users.
This is the same codebase as v5.1.1

@nan-li nan-li merged commit caf6dd9 into main Mar 6, 2024
3 checks passed
@nan-li nan-li deleted the release_5.1.2 branch March 6, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkasten2 jkasten2 jkasten2 approved these changes

@emawby emawby Awaiting requested review from emawby

@jennantilla jennantilla Awaiting requested review from jennantilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nan-li @jkasten2