[Bug] Some pending properties can be sent to new user incorrectly, when users change #1418

* We don't need the reference to the property model for an Update User request, and this reference has gone unused so far * We don't hydrate from the response as the response is not the full user, just the property that was updated. * The request still has a reference to the identity model it is operating on

* OneSignalCoreMocks now has XCTest dependency * It uses a waiter to allow the test to wait for any async calls to run, because we don't have control over all threads. For example, a test may need to wait for operation repo to run everything in the dispatch queue

* We will need to know if a particular payload exists in a dictionary to confirm what requests are sending

* Adds additional property to track if all requests have been handled by mock responses set * Adds method to use in asserts to confirm if there is only one executed request that contains the payload provided, and the url matches the path provided.f

* Change OneSignalUserTests build configs to "Test" * Add OS_TEST preprocessor macro (Test) to OneSignalOSCore which is needed for the reduced flush interval

* Starts with anon user, log into 2 users via Identify User and Create User * Add tags to each user

* The model on a Delta for property change is the properties model. However, the identity is needed to send the request. * We have been setting the identity model as the current user's when these Deltas become Requests. * However, the timing can be buggy when we flush Deltas when users change. The Operation Repo and Property Executor use a dispatch queue so by the time the request is made, the user may have changed.

* Introduce OSIdentityModelRepo managed by the User Manager where a dictionary of identity models live * This will hold identity models added when users change * When requests are uncached, their identity models will also be added as they are still being used. * This is a lightweight option over modifying the Identity Model Store (which is an option if we wish to use the model store to manage all identity models)

* When Requests are uncached in the executors, hook them up to the same identity model instance via the Identity Model Repo

* Also move its reset methods into an extension

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] Some pending properties can be sent to new user incorrectly, when users change #1418

[Bug] Some pending properties can be sent to new user incorrectly, when users change #1418

Commits on Apr 29, 2024