Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup IAM window on the main thread when failing to load #1447

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented May 30, 2024

Description

One Line Summary

Fix crash that can occur in some cases when we fail to load an IAM

Details

If multiple IAMs have the same trigger then we will have an IAM window that needs to be cleaned up when one of them fails to load. This fix was introduced in this pr, but the failure is not guaranteed to return on the UI thread so it would crash in some cases.

Motivation

Fix crash

Scope

IAM

Testing

Unit testing

none

Manual testing

Manually reproduced with break points and pausing active IAMs as they were about to load

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

…sage content

All other cleanups are coming from the UI thread, but this one is not. This fixes a crash that happens if multiple IAMs have the same trigger and one of the IAMs after the first fails to load
@emawby emawby merged commit 25f0657 into main Jun 3, 2024
3 of 4 checks passed
@emawby emawby deleted the fix/crash_when_failing_to_load_IAM branch June 3, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants