Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The user executor needs to uncache before other executors #1465

Merged
merged 3 commits into from
Aug 2, 2024
Merged

[Bug] The user executor needs to uncache before other executors #1465

merged 3 commits into from
Aug 2, 2024
+169 −147

Commits on Jul 26, 2024

  1. User executor is no longer a static class 

    * Primary Motivation: After a dispatch queue was added to the user executor, it's uncaching can happen on a background thread. However, when the User Manager starts, the user executor needs to finish uncaching first before other executors begin uncaching. This is because their uncached requests rely on the identity models organized by the user executor. By happening on a background thread, this order is not guaranteed. By making the User Executor an instance instead of a static class, it can uncache in its initializer without concurrency dangers.
* Additional motivations include Identity Verification work that allows the user executor to conform to the same listener protocol as other executors.
* All other executors are instances owned by the User Manager.
* Make the User Executor also an instance owned by the User Manager, as it is the only class that calls it.
* Access to user executor is force unwrapped because everything is guarded behind the User Manager's `start()` call. This will surface any issues or wrong usages early.
    @nan-li
    nan-li committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6eda3bf View commit details
    Browse the repository at this point in the history

  2. nit: Fix a string description to simplify tests 

    * Fix the string description of OSRequestCreateUser to be uniform
    @nan-li
    nan-li committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    eede113 View commit details
    Browse the repository at this point in the history

  3. no logic change - organize executor startup code 

    * No logic changes here, just break up executor code into digestible functions
    @nan-li
    nan-li committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    eb58e4f View commit details
    Browse the repository at this point in the history