Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Include debug symbols (dSYM) in the SDK #1519

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[feat] Include debug symbols (dSYM) in the SDK #1519

merged 4 commits into from
Nov 22, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Nov 21, 2024

Description

One Line Summary

Add debug symbols step to build script to include dSYM files in the SDK release.

Details

  • Only the first 2 commits are relevant.
  • The last 2 commits are for testing and will be removed after PR review.

Motivation

  • On Xcode 16, SDK consumers were getting warnings about missing dSYMS. While app validation still succeeds, the warnings can be alarming or a nuisance. On previous Xcode versions, the warnings were not generated.
  • This may also now help us symbolicate crash reports better

Scope

  • Debug symbols only

Testing

Manual testing

How to Test
You can test using the steps under Testing the SDK in another app without release in our internal OneSignal-iOS-SDK Release Documentation.

I tested adding the SDK via both Cocoapods and Swift Package Manager. On both:

  • app runs as expected
  • the warnings went away

before_with_warnings

after_without_warnings

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

All frameworks update the build setting "Debug Information Format" -> "DWARF with dSYM File" for all of Debug, Release, and Test
When building the frameworks, include debug symbols
Base automatically changed from fix/NSInvalidArgument-Exception to main November 21, 2024 19:11
@nan-li nan-li merged commit d3367c2 into main Nov 22, 2024
1 of 2 checks passed
@nan-li nan-li deleted the dsym branch November 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants