Add auth hash to external Id #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
309e9b7
to
9589356
Compare
* Add auth to setExternalId * Add tests for new functionality
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
9589356
to
14d80dc
Compare
jkasten2
approved these changes
Nov 16, 2020
jkasten2
requested changes
Nov 17, 2020
| return; | ||
| } else if (!self.currentSubscriptionState.userId || !self.app_id) { | ||
| [OneSignal onesignal_Log:ONE_S_LL_WARN message:[NSString stringWithFormat:@"Attempted to set external user id, but %@ is not set", self.app_id == nil ? @"app_id" : @"user_id"]]; | ||
| return; | ||
| } else if (self.currentEmailSubscriptionState.requiresEmailAuth && !hashToken) { |
There was a problem hiding this comment.
self.currentEmailSubscriptionState.requiresEmailAuth should be checking requiresUserIdAuth instead
emawby
approved these changes
Nov 20, 2020
Jeasmine
force-pushed
the
feature/external-id-auth
branch
from
1e66130
to
9af58b5
Compare
Jeasmine
added a commit
that referenced
this pull request
Nov 20, 2020
* Add auth to setExternalId * Add tests for new functionality * Add failure block to external id methods * Add tests for external id auth validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs name params validation
This change is