Give user the ability to disable onesignal load #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of one signal (including me) are experiencing crash in Simulator mode. This commit allows users the option to turn off oneSignal functionality by using NSProcessInfo arguments. To disable, use “DISABLE_ONESIGNAL_SWIZZLING” in “arguments passed on launch” in the scheme setup
…oFixCrash Give user the ability to disable onesignal load
jkasten2
changed the title
Jeasmine
reviewed
Mar 11, 2021
| @@ -2760,6 +2765,12 @@ +(void)setupUNUserNotificationCenterDelegate { | |||
| [OneSignalHelper registerAsUNNotificationCenterDelegate]; | |||
| } | |||
|
|
|||
| +(BOOL) shouldDisableBasedOnProcessArguments { | |||
| if ([NSProcessInfo.processInfo.arguments containsObject: @"DISABLE_ONESIGNAL_SWIZZLING"]) { | |||
There was a problem hiding this comment.
Nit comment, is ok to have the scape between containsObject: @"DISABLE_ONESIGNAL_SWIZZLING" ?
Jeasmine
approved these changes
Mar 11, 2021
emawby
approved these changes
Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request to merge a community PR #297 into master. I have tested this on iOS 14.4 and Xcode 12.4 myself.
This change is