Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alert for launch URLs #901

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Mar 15, 2021

This alert was causing problems for customers where it could be dismissed when the app was opened. It does not seem to be a desirable function so we will remove it. This change in behavior will need to be communicated to customers, but the change will not cause any build issues.

This change is Reviewable

@emawby emawby linked an issue Mar 15, 2021 that may be closed by this pull request
This alert was not desired by customers and was causing issues where the alert could be dismissed automatically on app open by customer code.
@emawby emawby force-pushed the fix/remove_alert_for_launch_urls branch from 438cde2 to 319d556 Compare March 15, 2021 19:22
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine)

@emawby emawby merged commit b48f6b5 into master Mar 15, 2021
@emawby emawby deleted the fix/remove_alert_for_launch_urls branch March 15, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always displaying Open Website? prompt on hard launch
2 participants