External user id not being sent fix #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeasmine
reviewed
Mar 17, 2021
| @@ -148,6 +148,13 @@ - (void)registerUserWithState:(OSUserState *)registrationState withSuccess:(OSMu | |||
| //update push player id | |||
| if (results.count > 0 && results[OS_PUSH][@"id"]) { | |||
| self.currentSubscriptionState.userId = results[OS_PUSH][@"id"]; | |||
|
|
|||
| // Player record was deleted so we should reset external user id | |||
| let cachedPlayerId = [OneSignalUserDefaults.initStandard getSavedStringForKey:OSUD_PLAYER_ID_TO defaultValue:nil]; | |||
There was a problem hiding this comment.
When the player is deleted from the server on Android, we clean userId and all cached data for that player. Finally, re-trigger the player's creation. Maybe we want the same behavior here?
There was a problem hiding this comment.
We probably do, but I would like to release this fix quickly so I don't want to increase the scope too much. We are already clearing the external user id and player id (by setting it to the new value). Why do we need to re-trigger player creation?
jkasten2
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Jeasmine)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two scenarios where we were not sending the external user id when we should be.
This change is