Merge pull request #414 from Nightsd01/master

Fix setEmail and improve readme

CONTRIBUTING.md

@@ -0,0 +1,33 @@
+# Contributing to the OneSignal React-Native SDK
+
+:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
+
+### How to Contribute
+We love the open source community and enjoy the support and contributions of many of our users. We ask that any potential contributors to the SDK Follow the following guidelines:
+
+If your proposed contribution is a small bug fix, please feel free to create your own fork of the repository and create a pull request.
+
+If your contribution would _break_ or _change_ the functionality of the SDK, please reach out to us on (contact) before you put in a lot of effort into a change we may not be able to use. We try our best to make sure that the SDK remains stable so that developers do not have to continually change their code, however some breaking changes _are_ desirable, so please get in touch to discuss your idea before you put in a lot of effort.
+
+#### Reporting Bugs
+If you have found a bug with the SDK, please feel free to open an Issue. 
+
+If you are pretty certain that the issue is only related to the native iOS SDK, please open the issue in our [native iOS SDK repository](https://github.com/OneSignal/OneSignal-iOS-SDK).
+
+If you are certain the issue is contained to the Android SDK, please open the issue in our [Android SDK repository](https://github.com/OneSignal/OneSignal-Android-SDK)
+
+#### Before Submitting A Bug Report
+Before creating bug reports, please check this list of steps to follow.
+
+1. Make sure that you are actually encountering an _issue_ and not a _question_. If you simply have a question about the SDK, we would be more than happy to assist you in our Support section on the web (https://www.onesignal.com - click the Message button at the bottom right)
+2. Please make sure to [include as many details as possible](#how-do-i-submit-a-good-bug-report)
+
+> **Note:** If you find a **Closed** issue that seems like it is the same thing that you're experiencing, open a new issue and include a link to the original issue in the body of your new one.
+
+
+#### How Do I Submit a Good Bug Report
+* **Use a clear and descriptive title** for the issue to identify the problem.
+* **Include Reproducibility** It is nearly always a good idea to include steps to reproduct the issue. If you cannot reliably reproduce the issue yourself, that's ok, but reproducible steps help best.
+* **Describe your environment**, tell us what version of react-native your app is using, what version of the react-native-onesignal SDK you're using, how you added it to your project, and so on.
+* **Include a Stack Trace** If your issue involves a crash/exception, ***PLEASE*** post the stack trace to help us identify the root issue.
+* **Include an Example Project** This isn't required, but if you want your issue fixed quickly, it's often a good idea to include an example project as a zip and include it with the issue. You can also download the Demo project (included in the `/examples` folder of this repo) and set up an example project with this code as a starting point.

README.md

@@ -159,6 +159,8 @@ android {
 
 ### Adding the Code
 
+<details><summary>Objective-C</summary><p>
+
  * in `AppDelegate.h`:
    * Import `RCTOneSignal.h`:
 
@@ -186,13 +188,49 @@ android {
         self.oneSignal = [[RCTOneSignal alloc] initWithLaunchOptions:launchOptions
                                                                appId:@"YOUR_ONESIGNAL_APP_ID"];
         ```
-
+    * You can also pass settings to OneSignal to control various effects, such as whether OneSignal automatically asks for permission to send push notifications shortly after launch or not.
         ```objc
-  	    // For requiring push notification permissions manually.
         self.oneSignal = [[RCTOneSignal alloc] initWithLaunchOptions:launchOptions
                                                                appId:@"YOUR_ONESIGNAL_APP_ID"
                                  settings:@{kOSSettingsKeyAutoPrompt: @false}];
         ```
+</p></details>
+
+<details><summary>Swift</summary><p>
+
+* If you don't already have one, create an Objective-C Bridging header for your project (`YourProjectName-Bridging-Header.h`) and import the React-Native-Onesignal library:
+
+```objc
+#import <RCTOneSignal.h>
+```
+ * In your AppDelegate, add the following property:
+
+ ```swift
+var oneSignal : RCTOneSignal!
+ ```
+
+* On the `application didFinishLaunchingWithOptions` method, insert the following code (replace YOUR_ONESIGNAL_APP_ID with your OneSignal app ID):
+
+```swift
+func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey : Any]? = nil) -> Bool {
+
+    self.oneSignal = RCTOneSignal(launchOptions: launchOptions, appId: "YOUR_ONESIGNAL_APP_ID");
+}
+
+```
+
+* You can also pass settings to OneSignal to control various effects, such as whether OneSignal automatically asks for permission to send push notifications shortly after launch or not.
+
+```swift
+func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey : Any]? = nil) -> Bool {
+
+    self.oneSignal = RCTOneSignal(launchOptions: launchOptions, appId: "YOUR_ONESIGNAL_APP_ID", settings: [kOSSettingsKeyAutoPrompt : false])
+}
+```
+
+</p></details>
+
+
 
 ### Add Notification Service Extension
 This step is optional but highly recommended. The `OneSignalNotificationServiceExtension` allows your application (in iOS) to receive rich notifications with images and/or buttons. If you do not follow this step, your application will not be able to show images in push notifications, and won't be able to add action buttons to notifications either.