Major Release #1044
Merged
Major Release #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgomezp
force-pushed
the
major-release
branch
4 times, most recently
from
5df0a89
to
fb25b1e
Compare
rgomezp
force-pushed
the
major-release
branch
6 times, most recently
from
bbf86b4
to
3fb0bc1
Compare
rgomezp
force-pushed
the
major-release
branch
4 times, most recently
from
fc1fd70
to
443b37c
Compare
jkasten2
requested changes
Oct 8, 2020
rgomezp
force-pushed
the
major-release
branch
2 times, most recently
from
c108157
to
05c71b9
Compare
emawby
suggested changes
Oct 9, 2020
emawby
suggested changes
Oct 14, 2020
jkasten2
requested changes
Oct 15, 2020
rgomezp
force-pushed
the
major-release
branch
3 times, most recently
from
86f6426
to
dc53fc6
Compare
* The `onesignal_app_id` and `onesignal_google_project_number` placehold values were droped from OneSignal-Android-SDK 4.0.0
…nesignal_manifest_placehold_values Cleanup - Android - Remove dropped onesignal manifest placeholder values
Jeasmine
force-pushed
the
major-release
branch
from
9c130c4
to
2aded3e
Compare
Motivation: the native iOS SDK changed the method name `onesignal_Log` to `onesignalLog` for consistency w/the native Android SDK method.
Upgrade to use version 4 of the Android SDK, version 3 of the iOS SDK
Motivation: since we have added user verification to external id setting and modification, we want to surface the error via the function callback by passing it to the JS side in case the error has relevant details. E.g: "External User Id authentication (auth token) is set to REQUIRED for this application. Please provide an auth token from your backend server or change the setting in the OneSignal dashboard."
Native SDK renamed the outcome event variable to `OSOutcomeEvent`
Motivation: this function was renamed to be clearer
Motivation: this should never have been required
Motivation: tags can be removed by sending a blank string. Here we're updating the logic to allow for that
Feature/merge master
Motivation: older devices may have older versions of Chrome which don't have support for ES6 syntax
Motivation: Rename `cancelNotification` to `removeNotification` for clarity
Motivation: update the types to reflect recent changes for user verification for setExternalUserId
Motivation: In the typings, the values for Authorized and Denied were backwards
Platform.OS is assigned to 'ios' in OSNotification.js and it affects all android settings in apps.
Motivation: there are multiple places in native `OneSignalOutcomeEventsController` where we call `success(nil)`. One example is calling `sendUniqueOutcome` multiple times. We should check that the `outcome` object is non-nil before passing it back to JS with the `jsonRepresentation` native method.
Motivation: - [Context](https://bit.ly/2WJbxHG) - Adds some logging in the iOS bridge to address the case that `outcome` object is nil
Motivation: we want Android bridge to match the iOS bridge. For this reason, we are removing the invocation of the callback altogether in the case that the outcome object is null.
* Initial Commit - Entire TS Example App * Update Yarn Lock to use latest Beta (beta 5) * Delete Non-TS Example App Motivation: moving forward we will only maintain the TS version * Refactor TS Example App Includes buttons for many functions * OSConsole to log events and variables * Finished Setting up Demo App * Update .gitignore Motivation: update .gitignore to ignore files from new example app * Commit XCode Config & Files * Commit Info.plist, Podfile lock file, and other project files * Add Error Handling for Getting Trigger Value For Key Motivation: Example app - add error handling for rejected `getTriggerValueForKey` promise. Also, remove JSON.stringify around second param to logging function as value is already stringified automatically inside that function. * Add Clear Handlers to Component Will Unmount Motivation: to avoid aggregating handlers/listeners, it is good practice to remove them before a component unmounts in the `componentWillUnmount` * Cross-Platform Conditional Formatting for Console Text * Add Location Permissions to Config Files Motivation: we want the example app to work with location out of the box. See reference: https://documentation.onesignal.com/docs/sdk-reference#location-data
* Update package.json files to 4.0.0 * Update Native SDK Versions * Remove native iOS files Motivation: these files were previously there in order to support non-cocoapods integrations. We are removing it here in the major release and will no longer be maintained moving forward. The manual linking process is likely done by a small portion of developers and introduces more room for error. Cocoapods is pretty standard at this point and can always be added back later or via SwiftPM in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Release
This PR upgrades this SDK to use the native SDK versions for iOS & Android of 3.0 & 4.0 respectively.
The migration guide can be found here.
API Additions
setAppIdfunctionaddPermissionObserveraddSubscriptionObserveraddEmailSubscriptionObserversetNotificationWillShowInForegroundHandlersetNotificationOpenedHandlerdisablePushgetDeviceStatedeleteTags(iOS) <- this was missed in the iOS bridge in previous releasesAPI Removals
configure(deprecated)init(no longer needed, this is done automatically)addEventListener(replaced by observers)getPermissionSubscriptionStatecheckPermissionsOther Changes
srcdirectoryEventManagerhelper class to manage events, listeners, and handlers related to those eventsNotificationReceivedEventclass to encapsulate the event & package it with the platform-specific payload as well as add acompletefunction prior to passing into the handler for thenotificationWillShowInForegroundeventhelpersfile for various miscellaneous helper functionsBefore merging
index.jssince it was moved into a different directorydeleteTagsreference in OneSignal docs