Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default callback function from setExternalUserId #1136

Merged
merged 1 commit into from
Jan 8, 2021

Commits on Jan 7, 2021

  1. Remove default callback function from setExternalUserId

    Motivation: this default callback isn't necessary because in the Java bridge the callback parameter is of type `final` which is `nullable`.
    
    This was prompted by the need for a workaround for a crash caused by having the external id and email set. If both are set, currently the native SDK triggers the `onSuccess` of each setter method to fire independently which is causing the passed in callback to fire twice, which is prohibited by React Native (crashes).
    rgomezp committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    30b5c81 View commit details
    Browse the repository at this point in the history