[ios] fix array resolve in request permission #1721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the
requestNotificationPermission
method on iOS incorrectly resolved the promise with an array instead of a boolean value.Details
Motivation
The TypeScript type definition for the
requestPermission
function specifies that it should return aPromise<boolean>
, indicating a promise that resolves to a boolean value. However, on iOS, the method was actually resolving the promise with an array containing the boolean value. This mismatch between the type definition and the actual return value caused issues in applications that relied on therequestPermission
function returning a simple boolean value.Scope
This change only affects the
requestNotificationPermission
method in the iOS SDK. It does not change the behavior of any other methods or functionalities.Testing
Manual testing
Manually tested the
requestNotificationPermission
method on a real iOS device and verified that the promise now correctly resolves with a boolean value.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is