Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements #525

Open
1 of 2 tasks
jrosindell opened this issue Mar 13, 2022 · 5 comments
Open
1 of 2 tasks

Accessibility improvements #525

jrosindell opened this issue Mar 13, 2022 · 5 comments

Comments

@jrosindell
Copy link
Member

jrosindell commented Mar 13, 2022

It has been reported that excessive zooming can trigger migraine and we want to enhance accessibility for the users where this applies. Similarly, free scrolling on pages can be a trigger for the same people and they use page up and page down buttons to avoid it but this does not work on the tabs that open up when clicking on a leaf.

There is some low hanging fruit here....

  • Page up and Page down doesn't work on a tab from a leaf because the user needs to click on it first to make the browser focus on the content of that item. This could perhaps be changed so the focus switch is automatic when the user opens the tabs or clicks on a new tab.
  • have an option in the settings to suppress all animations (like the jump feature, but stronger because short distances and clicks still result in zooming over short distances when jump is selected)
@lentinj
Copy link
Collaborator

lentinj commented Mar 14, 2022

Re: (2), is there really a use-case to expose all 3 of "Fly to [search] results", "Jump to [search] results, fly to signpost-clicks" and "Jump to search and signpost-clicks"? Explaining succinctly what each of the options would do feels hard work.

Life would be simpler for everyone IMO if the existing search jump/fly setting also applied to clicking on signposts, etc.

@lentinj
Copy link
Collaborator

lentinj commented Mar 14, 2022

Kinda related to the issue in hand. When I click on an image in an interior node, we always leap to the associated leaf node, regardless of anim=zoom. Should we also honour anim here too?

@lentinj
Copy link
Collaborator

lentinj commented Mar 14, 2022

What I think should be done is:

  • Combine all of "leap" / "fly_node" / "tap2zoom" to point at default_move_to()
  • Move default_move_to() into controller_anim (from controller_search)
  • Relabel the anim settings menu from "search mode" to "navigation" (or something else more common)

...but worth having a chat before actually committing.

lentinj added a commit that referenced this issue Mar 14, 2022
Upon opening a tab, make sure the iframe is focused so any keyboard
shortcuts within the content (e.g. pageup/down in wikipedia) work off
the bat.
lentinj added a commit that referenced this issue Mar 14, 2022
There are no "fly" button actions, it's equivalent to others anyway.
Remove reduntant code.
@lentinj
Copy link
Collaborator

lentinj commented Mar 15, 2022

Move on from this; ideally we'd have a box to highlight the later zoomed region so we can follow signposts.

Not worth it for now

@lentinj
Copy link
Collaborator

lentinj commented Dec 27, 2024

There's a CSS flag we could listen to here, rather than needing another checkbox: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

I suspect that this isn't something users would know how to use though, unless they also read MDN on a regular basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants