Skip to content

Commit

Permalink
fix bbm check info (#8186)
Browse files Browse the repository at this point in the history
* fix bbm check info

* add exception testcase

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
simonJJJ and mergify[bot] authored May 13, 2022
1 parent 0ad6733 commit b41549c
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 6 deletions.
16 changes: 10 additions & 6 deletions oneflow/core/functional/impl/nn_functor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,16 @@ class BatchMatMulFunctor {
const bool& transpose_b, const double& alpha) const {
const auto& a_shape = a->shape();
const auto& b_shape = b->shape();
CHECK_GE_OR_RETURN(a_shape->NumAxes(), 3) << "Tensor a's dim should >= 3";
CHECK_GE_OR_RETURN(b_shape->NumAxes(), 3) << "Tensor b's dim should >= 3";
CHECK_GE_OR_RETURN(a_shape->At(0), b_shape->At(0))
<< "batch dim not match, please check input!";
CHECK_GE_OR_RETURN(a_shape->At(2), b_shape->At(1))
<< "matmul dim not match, please check input!";
CHECK_EQ_OR_RETURN(a_shape->NumAxes(), 3)
<< Error::RuntimeError() << "Expected 3-dimensional tensor, but got " << a_shape->NumAxes()
<< "-dimensional tensor for argument #1";
CHECK_EQ_OR_RETURN(b_shape->NumAxes(), 3)
<< Error::RuntimeError() << "Expected 3-dimensional tensor, but got " << b_shape->NumAxes()
<< "-dimensional tensor for argument #2";
CHECK_EQ_OR_RETURN(a_shape->At(0), b_shape->At(0))
<< Error::RuntimeError() << "Batch dim not match, please check input!";
CHECK_EQ_OR_RETURN(a_shape->At(2), b_shape->At(1))
<< Error::RuntimeError() << "Matmul dim not match, please check input!";
MutableAttrMap attrs;
JUST(attrs.SetAttr<bool>("transpose_a", transpose_a));
JUST(attrs.SetAttr<bool>("transpose_b", transpose_b));
Expand Down
36 changes: 36 additions & 0 deletions python/oneflow/test/exceptions/test_bmm.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
"""
Copyright 2020 The OneFlow Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
"""

import unittest

import oneflow as flow
import oneflow.unittest


@flow.unittest.skip_unless_1n1d()
class TestBmm(flow.unittest.TestCase):
def test_bmm_exception_dim_not_right(test_case):
x = flow.tensor((2, 2))
with test_case.assertRaises(RuntimeError) as ctx:
y = flow.bmm(x, x)
test_case.assertTrue(
"Expected 3-dimensional tensor, but got 1-dimensional tensor for argument #1"
in str(ctx.exception)
)


if __name__ == "__main__":
unittest.main()

0 comments on commit b41549c

Please sign in to comment.